I was making a datapack and some of the advancements don't work. Specifically, the ones for finding Ocean ruins, Shipwrecks and Buried Treasure. In short, all the structures added in 1.13.

I'm sure I've spelt the structure names right because the advancement seems to automatically give itself to you if that's misspelled.