Uploaded image for project: 'Minecraft: Java Edition'
  1. Minecraft: Java Edition
  2. MC-140690

Giant Spruce Taiga Hills has no difference with Giant Spruce Taiga


    • Icon: Bug Bug
    • Resolution: Fixed
    • 21w37a
    • Minecraft 1.13.2, Minecraft 18w48a, Minecraft 18w48b, Minecraft 18w49a, Minecraft 18w50a, Minecraft 19w02a, Minecraft 19w03a, Minecraft 19w03b, Minecraft 19w03c, Minecraft 19w04a, Minecraft 19w04b, Minecraft 19w05a, Minecraft 19w06a, Minecraft 19w07a, Minecraft 19w08a, Minecraft 19w08b, Minecraft 19w09a, Minecraft 19w11a, Minecraft 19w11b, Minecraft 19w12a, Minecraft 19w12b, Minecraft 19w13a, Minecraft 19w13b, Minecraft 19w14a, Minecraft 19w14b, Minecraft 1.14 Pre-Release 1, Minecraft 1.14 Pre-Release 2, Minecraft 1.14 Pre-Release 3, Minecraft 1.14 Pre-Release 4, Minecraft 1.14 Pre-Release 5, Minecraft 1.14, Minecraft 1.14.1 Pre-Release 1, Minecraft 1.14.1 Pre-Release 2, Minecraft 1.14.1, Minecraft 1.14.2 Pre-Release 1, Minecraft 1.14.2 Pre-Release 2, Minecraft 1.14.2 Pre-Release 3, Minecraft 1.14.2 Pre-Release 4, Minecraft 1.14.2, Minecraft 1.14.3 Pre-Release 1, Minecraft 1.14.3 Pre-Release 2, Minecraft 1.14.3 Pre-Release 3, Minecraft 1.14.3 Pre-Release 4, Minecraft 1.14.3, Minecraft 1.14.4 Pre-Release 1, Minecraft 1.14.4 Pre-Release 2, Minecraft 1.14.4 Pre-Release 3, Minecraft 1.14.4 Pre-Release 4, Minecraft 1.14.4 Pre-Release 5, Minecraft 1.14.4 Pre-Release 6, 1.14.4, 19w34a, 19w35a, 19w36a, 19w37a, 19w38b, 19w38a, 19w39a, 19w40a, 19w41a, 19w42a, 19w44a, 19w45a, 19w45b, 19w46a, 19w46b, 1.15 Pre-release 1, 1.15 Pre-Release 2, 1.15 Pre-release 3, 1.15 Pre-release 4, 1.15 Pre-release 5, 1.15 Pre-release 6, 1.15 Pre-release 7, 1.15, 1.15.1, 1.15.1 Pre-release 1, 1.15.2 Pre-Release 1, 1.15.2 Pre-release 2, 1.15.2, 20w06a, 20w07a, 20w08a, 20w09a, 20w10a, 20w11a, 20w12a, 20w13a, 20w13b, 20w14a, 20w15a, 20w16a, 20w17a, 20w18a, 20w19a, 20w20a, 20w20b, 20w21a, 20w22a, 1.16 Pre-release 1, 1.16 Pre-release 2, 1.16 Pre-release 3, 1.16 Pre-release 4, 1.16 Pre-release 5, 1.16 Pre-release 6, 1.16 Pre-release 7, 1.16 Pre-release 8, 1.16 Release Candidate 1, 1.16, 1.16.1, 20w27a, 20w28a, 20w29a, 20w30a, 1.16.2 Pre-release 1, 1.16.2 Pre-release 2, 1.16.2 Release Candidate 1, 1.16.2 Release Candidate 2, 1.16.2, 1.16.3 Release Candidate 1, 1.16.3, 1.16.4 Pre-release 1, 1.16.4 Pre-release 2, 1.16.4 Release Candidate 1, 1.16.4, 20w45a, 20w46a, 20w48a, 20w49a, 20w51a, 21w03a, 1.16.5 Release Candidate 1, 1.16.5, 21w05a, 21w05b, 21w06a, 21w07a, 21w08a, 21w08b, 21w10a, 21w11a, 21w13a, 21w14a, 21w15a, 21w16a, 21w17a, 21w18a, 21w19a, 21w20a, 1.17 Pre-release 1, 1.17 Pre-release 2, 1.17 Pre-release 3, 1.17 Pre-release 5, 1.17 Release Candidate 1, 1.17 Release Candidate 2, 1.17, 1.17.1 Pre-release 1, 1.17.1 Pre-release 2, 1.17.1 Pre-release 3, 1.17.1 Release Candidate 2, 1.17.1
    • Confirmed
    • World generation
    • Low

      The bug :

      There is no difference beetween Giant Spruce Taiga Biome and Giant Spruce Taiga Hills Biome. The supposed hillier version is not. The problem is that the game isn't using correct values of setBaseHeight and setHeightVariation when generating the Giant Spruce Taiga Hills (Giant Spruce Taiga and Giant Spruce Taiga Hills are using the same values).

      This bug exists since these biomes were added in the game, in 1.7.2.

      It is not a feature suggestion, because it is clearly not intended. These biomes are coded exactly identical, only their name changes. Don't tell me that developpers intentionally added a "Hills" variant which is generating exactly like the non-Hill variant.

      How to reproduce :

      -Create a buffet world for each biome, and see that there is no difference beetween the two variants.

      -Or create a new world with the seed : 3743090988927099363

      Go at coordinates 0 ~ -2180. There is a river, with a Giant Spruce Taiga Hills on the north side and a Giant Spruce Taiga on the south side. You can see that there is no terrain's difference beetween them, Giant Spruce Taiga Hills isn't hillier.


      Giant Spruce Taiga :



      Giant Spruce Taiga Hills :



      Relief difference : 0



      If you're thinking it is a feature suggestion, see the code. There is differences beetween Giant Tree Taiga and Giant Tree Taiga Hills for example, but no difference at all beetween Giant Spruce Taiga and Giant Spruce Taiga Hills.


      Source code of Giant Spruce Taiga and Giant Spruce Taiga Hills :



      Comparison with source code of Giant Tree Taiga and Giant Tree Taiga Hills, which work as intended :


      Exact location of the code + all the source code of these 2 biomes :

      Location of Biome list :


      We can see on this screenshot that "giant_spruce_taiga" is using the bcv.class file, and that "giant_spruce_taiga_hills" is using the bcw.class file.

      We will comparate them to "giant_tree_taiga" and "giant_tree_taiga_hills" after, which use respectively bcx.class file and bcy.class file.



      Location of Giant Spruce Taiga Biome code :









      Location of Giant Spruce Taiga Hills Biome code :



      We also can see that everything is exactly the same. The Giant Spruce Taiga Hills Biome will not generate as intended, there won't be any difference with the Giant Spruce Taiga Biome.

      (You maybe noticed l.49, and thought that they were the wrong files. However, as we can see in the bbv.class.file, these bcv.class and bcw.class files are the ones used by Giant Spruce Biomes. I would guess that they use a part of Giant Tree Biomes files, which explains l.49)



      Comparison with bcx.class and bcy.class (used by Giant Tree Taiga biomes) :




      Here, the setBaseHeight value and the setHeightVariation value are correct. The Giant Tree Taiga Hills will generate as intended.


      Edit (1.14.4 Pre-Release 1) :

      In 1.14.4 Pre-Release 1, files names were changed (location is the same) :

      • biomes are now listed in .minecraft\versions\1.14.4-pre1\1.14.4-pre1.jar\biq.class
      • Giant Spruce Taiga Biome now uses .minecraft\versions\1.14.4-pre1\1.14.4-pre1.jar\bjq.class
      • Giant Spruce Taiga Hills Biome now uses .minecraft\versions\1.14.4-pre1\1.14.4-pre1.jar\bjr.class
      • Giant Tree Taiga Biome now uses .minecraft\versions\1.14.4-pre1\1.14.4-pre1.jar\bjs.class
      • Giant Tree Taiga Hills Biome now uses .minecraft\versions\1.14.4-pre1\1.14.4-pre1.jar\bjt.class
      • nothing else than locations changed, this is why I didn't update screenshots (that were taken in 18w49a)

      How to fix the bug :

      In the Giant Spruce Taiga Hills line code, change the value of setBaseHeight from 0.2F to 0.45F, and change the value of setHeightVariation from 0.2F to 0.45F

      This won't change the global world generation, but only the way this specific biome is generated (and this biome is rare so it will not cause any issue of bad world generation caused by updating from an older version).

      There is like 2 numbers to change, which will make more variety in Minecraft, as it was intended in the first place by creating Giant Spruce Taiga Hills in 1.7.2

      I hope it will get fix as soon as possible, there is really not much to do in order to fix this bug !

            Unassigned Unassigned
            Bazippo Valicon
            54 Vote for this issue
            24 Start watching this issue