Uploaded image for project: 'Minecraft: Java Edition'
  1. Minecraft: Java Edition
  2. MC-138918

Update light packet uses the wrong mask for empty block light

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Fixed
    • Minecraft 18w47a
    • Minecraft 18w44a, Minecraft 18w45a, Minecraft 18w46a
    • None
    • Unconfirmed

      When looking at the new update light packet, I've noticed that the masks for light nibble arrays that are all empty (the inner array is null) are written incorrectly. Both the sky light and the block light ones write to the same mask (this.e), while there is a separate mask that goes unused (this.f). This doesn't apply to the constructor that takes some existing masks to decide which sections to update, only the one that just takes the data.

      I'm not sure if this manifests itself ingame in any way; the only way I know of seeing this is by looking at the packet code itself. As of 18w44a, the two writes to this.e are on lines 38 and 46 of the actual code, and the packet itself is obfuscated as kz.

            fry [Mojang] Georgii Gavrichev
            pokechu22 [Mod] Pokechu22
            Votes:
            8 Vote for this issue
            Watchers:
            4 Start watching this issue

              Created:
              Updated:
              Resolved: