The bug

The advancement trigger minecraft:player_killed_entity is not triggered if a player kills itself, for instance by hitting themselves by using a bow, a crossbow, or a trident.

To reproduce

1. Download suicide_advancement_test.zip
2. Install the datapack in your world
3. Run /reload
4. Kill yourself with a bow
   → You don't get the advancement