Uploaded image for project: 'Minecraft: Java Edition'
  1. Minecraft: Java Edition
  2. MC-131356

The firework light flash is missing

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Resolved
    • Resolution: Fixed
    • Affects Version/s: Minecraft 1.13-pre2, Minecraft 1.13-pre3, Minecraft 1.13-pre4, Minecraft 1.13-pre5, Minecraft 1.13-pre6, Minecraft 1.13-pre8, Minecraft 1.13-pre9, Minecraft 1.13-pre10, Minecraft 1.13, Minecraft 18w30a, Minecraft 18w30b, Minecraft 18w31a, Minecraft 18w32a, Minecraft 18w33a, Minecraft 1.13.1-pre1, Minecraft 1.13.1-pre2, Minecraft 1.13.1, Minecraft 1.13.2-pre1, Minecraft 1.13.2-pre2, Minecraft 1.13.2, Minecraft 18w43a, Minecraft 18w43b, Minecraft 18w43c, Minecraft 18w44a, Minecraft 18w45a, Minecraft 18w46a, Minecraft 18w47a, Minecraft 18w47b, Minecraft 18w48a, Minecraft 18w48b, Minecraft 18w49a, Minecraft 18w50a, Minecraft 19w02a, Minecraft 19w03a, Minecraft 19w03b, Minecraft 19w03c, Minecraft 19w04a, Minecraft 19w04b, Minecraft 19w05a
    • Fix Version/s: Minecraft 19w06a
    • Labels:
      None
    • Confirmation Status:
      Confirmed

      Description

      The bug

      While testing for MC-4544, I noticed the light flash isn't displayed at all now. Not sure about this, but it probably is not an intended change (at least it is not mentioned in the 1.13-pre2 changelog).

       

      From Bob Morane:

      Fireworks use the index span between 72 and 191 for the big flash of the explosion, but that area is empty in the particles.png file (red square in the attachment). It was probably supposed to use the sprite bordered in orange (which would be the 36-87 square).

      Fireworks also use one too many sprite in their trail/spark animation and they go down to index 159. You can't notice it at first because the index is empty in the original  texture. But if you fix the first error (by painting an explosion flash in the red square), you notice that the last sprite of the trail samples from that same flash square! (blue square). One error hiding the other .

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                Unassigned
                Reporter:
                _zombiehunter [Helper] _zombiehunter
              • Votes:
                8 Vote for this issue
                Watchers:
                6 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  CHK: