Uploaded image for project: 'Minecraft: Java Edition'
  1. Minecraft: Java Edition
  2. MC-130183

Waterlogged blocks retain their waterlogged state when moved with sticky pistons with short pulse

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Open
    • Resolution: Unresolved
    • Affects Version/s: Minecraft 18w21a, Minecraft 1.13-pre1, Minecraft 1.13-pre2, Minecraft 1.13-pre3, Minecraft 1.13-pre6, Minecraft 1.13-pre7, Minecraft 1.13-pre8, Minecraft 1.13, Minecraft 18w32a, Minecraft 1.13.1-pre1, Minecraft 1.13.1, Minecraft 1.13.2, Minecraft 18w49a, Minecraft 19w09a, Minecraft 19w13a, Minecraft 1.14 Pre-Release 5, Minecraft 1.14.1 Pre-Release 1, Minecraft 1.14.2, 1.15 Pre-release 4, 1.15.1, 20w06a
    • Fix Version/s: None
    • Labels:
      None
    • Confirmation Status:
      Confirmed
    • Category:
      (Unassigned)

      Description

      The bug

      Waterlogged blocks retain their waterlogged state when moved with sticky pistons with short redstone pulse. Screenshots attached.

      Code analysis

      The same code that fixed MC-127474 in TileEntityPiston.update() needs to be added to TileEntityPiston.clearPistonTileEntity() to ensure pistons that update faster than 2 ticks (or are quick-pulsed) also set their waterlogged state to false.

      if(iblockstate.hasProperty(BlockStateProperties.WATERLOGGED) && iblockstate.getProperty(BlockStateProperties.WATERLOGGED))
      {
      	iblockstate = (IBlockState) iblockstate.withProperty(BlockStateProperties.WATERLOGGED, Boolean.valueOf(false));
      }
      

        Attachments

        1. after.JPG
          56 kB
          Michał
        2. before.JPG
          58 kB
          Michał

          Issue Links

            Activity

              People

              • Assignee:
                Ulraf [Mojang] Ulraf
                Reporter:
                Toboe_Irbis Michał
              • Votes:
                11 Vote for this issue
                Watchers:
                12 Start watching this issue

                Dates

                • Created:
                  Updated:
                  CHK: