Uploaded image for project: 'Minecraft: Java Edition'
  1. Minecraft: Java Edition
  2. MC-120513

The advancements overview can be opened while being in a nether portal

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Open
    • Resolution: Unresolved
    • Affects Version/s: Minecraft 1.12.1, Minecraft 1.12.2 Pre-Release 1, Minecraft 1.12.2 Pre-Release 2, Minecraft 1.12.2, Minecraft 17w49a, Minecraft 17w49b, Minecraft 17w50a, Minecraft 1.13.1
    • Fix Version/s: None
    • Confirmation Status:
      Confirmed
    • Category:
      (Unassigned)

      Description

      The bug

      Unlike all other GUIs, you can open the advancements overview while traveling to the nether or back.

      In singleplayer, the game is paused then while in multiplayer, the game continues to run, causing the advancements overview to be closed as soon as you've changed the dimension.

      How to reproduce

      1. Enter a portal
      2. Press the "Advancements overview" key (default: L)

      Code analysis

      In class EntityPlayerSP, in function onLivingUpdate, it is defined that a screen's doesGuiPauseGame function must return false if it should not be able to be shown.

      If that function is implemented into GuiScreenAdvancements like so:

      GuiScreenAdvancements.java
      public boolean doesGuiPauseGame()
      {
          return false;
      }
      

      the overview can not be invoked while the player is inside of a portal. However, this also causes the overview to disappear when you open it from the pause menu while standing inside of a portal; and also the game does not stop while being in the advancements overview, which probably is not intended.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                Unassigned
                Reporter:
                violine1101 [Mod] violine1101
              • Votes:
                5 Vote for this issue
                Watchers:
                5 Start watching this issue

                Dates

                • Created:
                  Updated:
                  CHK: