Uploaded image for project: 'Minecraft: Java Edition'
  1. Minecraft: Java Edition
  2. MC-115092

Squid named "Dinnerbone" or "Grumm" is not upside-down

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Open
    • Resolution: Unresolved
    • Affects Version/s: Minecraft 1.11.2, Minecraft 17w13a, Minecraft 17w16b, Minecraft 1.12 Pre-Release 7, Minecraft 1.12.1, Minecraft 1.12.2, Minecraft 1.13, Minecraft 1.13.1-pre1, Minecraft 1.13.1, Minecraft 1.13.2, Minecraft 18w43c, Minecraft 18w44a, Minecraft 18w45a, Minecraft 19w03b, Minecraft 19w03c, Minecraft 19w05a, Minecraft 19w06a, Minecraft 19w07a
    • Fix Version/s: None
    • Confirmation Status:
      Confirmed

      Description

      The bug

      Squid named "Dinnerbone" or "Grumm" is not upside-down

      How to reproduce

      Use the following command to summon a squid named Dinnerbone:

      /summon minecraft:squid ~ ~ ~ {CustomName:"{\"text\":\"Dinnerbone\"}",CustomNameVisible:1b,Silent:1b,NoAI:1b} 
      

      Code analysis

      Based on 1.12.2 MCP names.
      In the method net.minecraft.client.renderer.entity.RenderSquid.applyRotations() where it applies the squid's model rotations, it does not have a check if the squid is named Dinnerbone or Grumm and to rotate if so. To fix this issue, this piece of code can be added at the end of the method applyRotations().

          String s = TextFormatting.getTextWithoutFormattingCodes(entityLiving.getName());
      
              if (s != null && ("Dinnerbone".equals(s) || "Grumm".equals(s)))
              {
                  GlStateManager.translate(0.0F, entityLiving.height + 0.1F, 0.0F);
                  GlStateManager.rotate(180.0F, 0.0F, 0.0F, 1.0F);
              }
      

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                Unassigned
                Reporter:
                OMGItzAndrew Andrew David Gronowski
              • Votes:
                7 Vote for this issue
                Watchers:
                7 Start watching this issue

                Dates

                • Created:
                  Updated:
                  CHK: