Details

    • Confirmation Status:
      Confirmed

      Description

      There is a part of the World code (method net.minecraft.world.World.getRawLight(BlockPos, EnumSkyBlock) (MCP name)) that checks light where a MutableBlockPos is retained but not released.

      Before the last return, the MutableBlockPos is released.
      For the first return, it is not.

      World.java
      else
      {
      	BlockPos.PooledMutableBlockPos blockpos$pooledmutableblockpos = BlockPos.PooledMutableBlockPos.retain();
      
      	for (EnumFacing enumfacing : EnumFacing.values())
      	{
      		blockpos$pooledmutableblockpos.setPos(pos).move(enumfacing);
      		int k = this.getLightFor(lightType, blockpos$pooledmutableblockpos) - j;
      
      		if (k > i)
      		{
      			i = k;
      		}
      
      		if (i >= 14)
      		{
      			return i;
      		}
      	}
      
      	blockpos$pooledmutableblockpos.release();
      	return i;
      }
      

        Attachments

          Activity

            People

            • Assignee:
              dinnerbone [Mojang] Dinnerbone (Nathan Adams)
              Reporter:
              mezz mezz
            • Votes:
              3 Vote for this issue
              Watchers:
              7 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                CHK: