Minecraft
  1. Minecraft
  2. MC-110783

Final firework rocket of a stack does not explode

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Resolution: Fixed
    • Affects Version/s: Minecraft 1.11
    • Fix Version/s: Minecraft 16w50a
    • Security Level: Minecraft - Public (Viewable by everyone)
    • Labels:
    • Confirmation Status:
      Confirmed

      Description

      From a stack of firework rockets, all explode correctly but the final one: The final one does not explode at all. (For a stack of one rocket, this looks as if no rocket would explode.)

      This happens regardless whether the rockets are placed directly by a player or if they are launched from a dispenser.

      This was not observed before in Minecraft Version 1.10 on the same system.

      Code analysis

      Based on 1.11 decompiled using MCP 9.35 rc1

      This happens because the constructor net.minecraft.entity.item.EntityFireworkRocket.EntityFireworkRocket(World, double, double, double, ItemStack) saves the used item as FireworksItem instead of a copy of it. This means when you use the last firework item, the stored item has the count of 0 and is invalid.

        Issue Links

          Activity

          Hide
          Joachim Schmid added a comment -

          Sorry, I forgot: This was observed both in Creative and Survival mode, no texture packs installed.

          Show
          Joachim Schmid added a comment - Sorry, I forgot: This was observed both in Creative and Survival mode, no texture packs installed.
          Hide
          [Helper] Dylan added a comment -

          Confirmed

          Show
          [Helper] Dylan added a comment - Confirmed
          Hide
          Valdir Neves added a comment -

          Confirmed

          Show
          Valdir Neves added a comment - Confirmed
          Hide
          [Mod] FVbico (Steven Verberne) added a comment -

          It's already marked as confirmed by a helper/mod.

          Show
          [Mod] FVbico (Steven Verberne) added a comment - It's already marked as confirmed by a helper/mod.

            People

            • Assignee:
              [Mojang] Maria Lemón
              Reporter:
              Joachim Schmid
            • Votes:
              4 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                CHK: