Minecraft
  1. Minecraft
  2. MC-108934

The "ench:[]" tag doesn't have glint with potions, but name is colored otherwise

    Details

    • Confirmation Status:
      Confirmed

      Description

      If a player give themselves a potion that has the "ench:[]" tag, the potion doesn't show the enchanted glint like other potions, however, the name of the potion is blue indicating that it's enchanted. The same is applied to the Water Bottle, Awkward, Mundane, Uncraftable, and Thick Potions respectively.

      The first two screenshots show the two potions with the right being a regular black potion, and the left being a potion with the "ench:[]" tag. They are black as to make the them more visible. As the last picture is the two of them side by side, with the potion tab opened for reference. The bug also applies to the splash potion and lingering potion counterparts.

      This is weird as I'm pretty sure this worked in 1.8 (Please confirm).

      Many other items don't seem to have this issue with the "ench:[]" tag.

      Example command
      /give @p potion 1 0 {Potion:"minecraft:water",ench:[]}
      
      1. 2016-10-19_15.13.53.png
        57 kB
      2. 2016-10-19_15.13.59.png
        58 kB
      3. 2016-10-19_15.14.10.png
        54 kB
      4. 2016-11-09_06.31.22.png
        117 kB
      5. 2016-11-09_06.31.30.png
        116 kB
      6. 2016-11-09_06.31.35.png
        116 kB
      7. 2016-11-09_06.31.39.png
        114 kB

        Issue Links

          Activity

          Hide
          Sion Richards added a comment -

          In the new pre-release it seems only enchantable items have the glint display when they have the ench:[] tag. My custom items have the tag but display normally, all tools are still the same.

          Show
          Sion Richards added a comment - In the new pre-release it seems only enchantable items have the glint display when they have the ench:[] tag. My custom items have the tag but display normally, all tools are still the same.
          Hide
          [Mod] Skylinerw added a comment - - edited

          @Sion Richards It's a bit different than that: the ench tag now requires there to be a compound existing within it. The id and lvl tags will default to 0, but you can set lvl to -1 to avoid applying the Protection enchantment (and will display as it did when using ench:[]).

          /give @p minecraft:stone 1 0 {ench:[{id:-1s}]}
          Show
          [Mod] Skylinerw added a comment - - edited @ Sion Richards It's a bit different than that: the ench tag now requires there to be a compound existing within it. The id and lvl tags will default to 0, but you can set lvl to -1 to avoid applying the Protection enchantment (and will display as it did when using ench:[] ). /give @p minecraft:stone 1 0 {ench:[{id:-1s}]}
          Hide
          Littleman9Mew2 added a comment - - edited

          I don't think the bug here was fixed, in fact it still didn't do anything to potions. As applying the Ench:[(id:0)] tag still doesn't do anything to potions. I do the same to any other item and the effect shows. One fix should be to make so that the "ench:[]" tag overwrites the potion enchantment effect.

          The issue I see is how potions are enchanted based on the effect and not the tag. If it's a potion without a glint, it wont show a glint, no matter what. But if it does, it always shows the glint. However!! I don't what it so that items cannot be enchanted at all, as that will break a lot of immersion and command block contraptions. Really the change should be reverted as it didn't do anything besides break everything in previous snapshots. I'm only stating that only potions are still effected because of the weird way the enchantment glint applies to them.

          Show
          Littleman9Mew2 added a comment - - edited I don't think the bug here was fixed, in fact it still didn't do anything to potions . As applying the Ench: [(id:0)] tag still doesn't do anything to potions. I do the same to any other item and the effect shows. One fix should be to make so that the "ench:[]" tag overwrites the potion enchantment effect. The issue I see is how potions are enchanted based on the effect and not the tag. If it's a potion without a glint, it wont show a glint, no matter what. But if it does, it always shows the glint. However!! I don't what it so that items cannot be enchanted at all , as that will break a lot of immersion and command block contraptions. Really the change should be reverted as it didn't do anything besides break everything in previous snapshots. I'm only stating that only potions are still effected because of the weird way the enchantment glint applies to them.
          Hide
          CDES5 (Inactive) added a comment - - edited

          Is it Fixed or not?

          Show
          CDES5 (Inactive) added a comment - - edited Is it Fixed or not?
          Hide
          [Mod] Skylinerw added a comment -

          @CDES5 Look at the resolution, which says "Unresolved". The list of fixed versions is not removed; it states the versions that it was attempted to be fixed. The resolution status is what's important.

          Show
          [Mod] Skylinerw added a comment - @ CDES5 Look at the resolution, which says "Unresolved". The list of fixed versions is not removed; it states the versions that it was attempted to be fixed. The resolution status is what's important.
          Hide
          [Mojang] Grum (Erik Broes) added a comment -

          The fix was to remove the blue text if there is not an actual enchant

          Show
          [Mojang] Grum (Erik Broes) added a comment - The fix was to remove the blue text if there is not an actual enchant
          Hide
          [Helper] Marcono1234 added a comment -

          This is not really a fix like stated before.

          /give @p potion 1 0 {Potion:"minecraft:water",ench:[{id:1s,lvl:1s}]}
          

          is still the same way broken. You just removed a functionality which was widely used by the community :/

          Show
          [Helper] Marcono1234 added a comment - This is not really a fix like stated before. /give @p potion 1 0 {Potion: "minecraft:water" ,ench:[{id:1s,lvl:1s}]} is still the same way broken. You just removed a functionality which was widely used by the community :/
          Hide
          [Mojang] Grum (Erik Broes) added a comment - - edited

          ^^ is properly glinted in 1.11+

          Show
          [Mojang] Grum (Erik Broes) added a comment - - edited ^^ is properly glinted in 1.11+

            People

            • Assignee:
              [Mojang] Grum (Erik Broes)
              Reporter:
              Littleman9Mew2
            • Votes:
              3 Vote for this issue
              Watchers:
              10 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                CHK: