Uploaded image for project: 'Minecraft: Java Edition'
  1. Minecraft: Java Edition
  2. MC-106430

"Glowing" shader not reloaded on resource pack reload

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Resolved
    • Resolution: Fixed
    • Affects Version/s: Minecraft 1.10.2, Minecraft 16w41a, Minecraft 1.11.2, Minecraft 1.12.2, Minecraft 18w22c, Minecraft 1.13-pre1
    • Fix Version/s: Minecraft 19w08a
    • Confirmation Status:
      Confirmed

      Description

      The bug

      If I use a resource pack, to replace the glowing shader, and I load it, and open the game and use the glowing effect, nothing changes. If I restart the whole game, then go in the world though, the changes will take effect. The same goes for changing it back. I believe this may be because minecraft loads the shader and caches it on minecraft load, and that this could be fixed by simply reloading the glowing shader when the resource pack is reloaded.

      Code analysis

      The following is based on a decompiled version of Minecraft 1.10 using MCP 9.30.

      The method net.minecraft.client.renderer.RenderGlobal.makeEntityOutlineShader() is only called when the game is started, whereas the other shaders (creeper, enderman, spider) are reloaded when the resource manager is reloaded. This could be solved by having the method net.minecraft.client.renderer.RenderGlobal.onResourceManagerReload(IResourceManager) call this method and calling the resetting method which is probably net.minecraft.client.shader.ShaderGroup.deleteShaderGroup().

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                dinnerbone [Mojang] Nathan Adams
                Reporter:
                minecreatr Daniel HD
              • Votes:
                5 Vote for this issue
                Watchers:
                8 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  CHK: